WorkflowAction should use Configurer style API

Description

Currently it uses builder style API. Should change it to configurer style similar to programs.

Release Notes

Added a new simplified API to configure a workflow action. The existing API has been deprecated.

Activity

Show:

Andreas Neumann September 18, 2015 at 4:36 AM
Edited

Turns out that the existing code is broken.

  • it does not call the proper configure() method when executing program actions.

  • it does not set the class name in the action spec if the action implements the WorkflowAction interface directly.

Both of these work if the action extends AbstractWorkflowAction but overrides the legacy configure() method. It does not work if it overrides the new configure() method. Also does not work if the action directly implements WorkflowAction.

I will try to fix these issues also here.

Andreas Neumann September 17, 2015 at 9:30 PM

Andreas Neumann September 17, 2015 at 9:28 PM

None of the guides configures a workflow action.

Andreas Neumann September 17, 2015 at 8:52 PM

Changing all internal uses (tests, examples, etl-apps) to use new style. Documentation does not explain the configure() method. I think that is ok, because it is so similar to other configurers.

Gokul Gunasekaran September 17, 2015 at 7:53 PM

Yes, since we have the existing configure() method, there was no other way. We can clean it up when we remove the deprecated API in 3.4.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Affects versions

Components

Fix versions

Priority

Created July 8, 2015 at 8:56 PM
Updated September 21, 2015 at 6:51 PM
Resolved September 18, 2015 at 7:36 AM