Use Dockerfile ENTRYPOINT to support arguments

Description

Suggesting to update the cdap dockerfile to permit the setting of the "--enable-debug" flag on the entrypoint though environment variable or other means

Release Notes

Created a Docker-specific ENTRYPOINT script to easily support arguments.

Activity

Show:

Chris Gianelloni June 6, 2016 at 6:58 PM

Updated Dockerfile to use an ENTRYPOINT script which borrowed heavily from the script used by the official elasticsearch Docker image.

Chris Gianelloni May 26, 2016 at 11:06 PM

Chris Gianelloni May 25, 2016 at 9:16 PM

I'm writing up an entrypoint file to replace how we currently just use the cdap.sh script directly.

This is more in line with Docker best practices.
https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/

David Bajot February 26, 2015 at 9:08 AM

What do we lose by by enabling debug by default? Is it just basically way more space consumed by logs? No expected performance hit as a result, right? (I would not think so).

Chris Gianelloni February 20, 2015 at 11:37 PM

We can enable it, period.... Otherwise, we need to create an entrypoint script to use as a wrapper, and change the ENTRYPOINT to be this wrapper, and let the wrapper handle the logging. This would allow someone to "docker run caskdata/cdap-standalone --enable-debug" and the arguments are passed to the wrapper to be interpreted.

This is probably the way to go, long run. My question is should be just --enable-debug in the short term? Environment, etc. won't work in this case, as nothing makes it from the host environment into the container environment.

Fixed
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Components

Fix versions

Priority

Created February 19, 2015 at 7:41 PM
Updated August 19, 2016 at 5:45 PM
Resolved June 6, 2016 at 6:58 PM