Do not unconditionally set node.default['hadoop']['distribution_version']

Description

I have a wrapper cookbook (of hadoop) that itself wishes to be wrapped. My use case is to establish a "generic" hadoop install for internal company applications. By committing to decisions that aren't necessarily appropriate for the community at large (but still internally acceptable) I am able to add desirable non-trivial application-agnostic features like service discovery and orchestration.

Being a wrapper cookbook that itself wishes to be wrapped, my cookbook tries to express configuration with only default attributes. Your hadoop cookbook generally plays well with this strategy.

However this block from recipes/repo.rb causes a problem:

This unconditionally sets the default value of node['hadoop']['distribution_version'], which prevents my choice of default from taking effect. It seems the issue could be resolved by guarding this assignment with an absence check, similar to other occurrences of attribute logic in the cookbook. Could you add this guard?

Release Notes

None

Activity

Show:
Chris Gianelloni
April 14, 2016, 11:27 PM
Chris Gianelloni
April 19, 2016, 2:27 PM

This has been merged to master and will be in the next cookbook release.

Phil Smith
April 19, 2016, 5:09 PM

Thanks for jumping on this, the fix looks good. I don't see any notion of release schedule around. Any idea when that might be?

Chris Gianelloni
April 19, 2016, 8:01 PM

We releases as-needed. We don't have a release schedule or a roadmap for the cookbooks. That being said, I am planning on putting out a patch release today with this and another change, yet to be merged. You can subscribe to notifications for the cookbook by either watching the GitHub repository, or watching the cookbook on Supermarket.

Fixed

Assignee

Chris Gianelloni

Reporter

Phil Smith

Labels

None

Docs Impact

None

UX Impact

None

Components

Priority

Major
Configure