We're updating the issue view to help you get more done. 

Customizing profiles in pipelines causes the popover to close

Description

  1. Deploy a pipeline

  2. Configure the pipeline to use a custom profile

  3. Customize the profile by changing the master cores.

After step 3 the popover closes instead of staying open. This blocks user from customizing the profile.

Release Notes

None

Activity

Show:
Ajai Narayanan
April 16, 2020, 10:43 PM

Root cause:

  • The implementation of {{Select}} changed in the newer implementation of material-ui.

  • Behind the hood it implemented {{React-Portal}} to show the dropdown.

  • This means all the events happening in the dropdown will be propagated to the parent (even though its not under the actual parent DOM node.) This event is bubbled up in React Tree.

  • We listen to click events in document to close the modeless (when clicked outside)

  • Because events now bubble up, a click on the Select now propagates up and closes the Pipeline configuration modeless.

  • Owing to lack of time I am reverting this change.

Fix for future

  • A proper fix moving forward will be to prevent the event propagation to not close the modeless. Given the hierarchy (Select -> SelectInput -> Menu -> Menu Item -> List item) it is getting hard to detect where and when this event is propagated and where it needs to be stopped.

Ajai Narayanan
April 16, 2020, 10:43 PM
Ajai Narayanan
May 6, 2020, 1:28 PM

Verified the fix by customizing profile and it worked as expected

Fixed

Assignee

Ajai Narayanan

Reporter

Ajai Narayanan

Docs Impact

None

UX Impact

None

Components

Fix versions

Priority

Blocker
Configure